Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of the navigation pane on iPad is shifted down #2191

Closed
ilg-ul opened this issue Mar 6, 2023 · 9 comments · Fixed by #2194
Closed

Rendering of the navigation pane on iPad is shifted down #2191

ilg-ul opened this issue Mar 6, 2023 · 9 comments · Fixed by #2194
Labels
bug Functionality does not match expectation good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged

Comments

@ilg-ul
Copy link

ilg-ul commented Mar 6, 2023

I noticed a small problem with rendering the generated site on an iPad: the navigation pane seems shifted down and the last link is not visible:

IMG_0253

When rendered with Safari on macOS, it is ok:

Screenshot 2023-03-06 at 17 27 20

The site was generated with 0.23.25.

@ilg-ul ilg-ul added the bug Functionality does not match expectation label Mar 6, 2023
@ilg-ul
Copy link
Author

ilg-ul commented Mar 6, 2023

On iPhone it is also ok:

IMG_2453

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 7, 2023

I don't have an iPad suitable for troubleshooting this - PR welcome

@Gerrit0 Gerrit0 added help wanted Contributions are especially encouraged good first issue Easier issue for first time contributors labels Mar 7, 2023
@ilg-ul
Copy link
Author

ilg-ul commented Mar 7, 2023

I have the iPad, but I don't have a CSS knowledge suitable for troubleshooting this. :-(

If someone can suggest a fix, I can test it.

@ilg-ul
Copy link
Author

ilg-ul commented Mar 7, 2023

Another question: are those large spaces between Setting, Modules and the list really necessary?

@ilg-ul
Copy link
Author

ilg-ul commented Mar 7, 2023

I just checked and the issue can be also reproduced using an iPad simulator. Just be sure you select a 4th or 5th generation iPad (9.7", 2048x1536) and landscape screen orientation. Interestingly enough, on larger iPads I could not reproduce the issue.

@futurGH
Copy link
Contributor

futurGH commented Mar 8, 2023

It's because certain iPads have the precise display dimensions (a computed width of 1024px) that would cause this edge case. My PR should resolve the top margin as well as the large spacing. Thanks for pointing it out.

@ilg-ul
Copy link
Author

ilg-ul commented Mar 8, 2023

a computed width of 1024px

Does this also apply to a 9.7" screen with 2048x1536?

@futurGH
Copy link
Contributor

futurGH commented Mar 8, 2023

Yeah. iOS devices, among others, have what's called a device pixel ratio. Although it has 2048 physical pixels across, that'd be illegible on a 9.7" display, so it presents browsers a width of 1024px and uses the pixels in between for stuff like finer font rendering; what Apple calls "retina".

@ilg-ul
Copy link
Author

ilg-ul commented Mar 8, 2023

Thank you @futurGH for the explanation.

So, if you think that this fix also applies to my iPad, and there is no need to test anything now, I'll wait for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants