Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad highlighted elements in sidebar #2229

Closed
RunDevelopment opened this issue Apr 9, 2023 · 0 comments
Closed

Pad highlighted elements in sidebar #2229

RunDevelopment opened this issue Apr 9, 2023 · 0 comments
Labels
enhancement Improved functionality good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged
Milestone

Comments

@RunDevelopment
Copy link
Contributor

Search Terms

sidebar

Problem

Linked elements in the sidebar have inconsistent padding. There's quite a bit in the y direction, but nothing in x.

image
image

This causes the kind icon to be too far left, which is visually displeasing

Suggested Solution

Please add a bit of padding to the sidebar elements with icons.

Example: same padding for x and y:
image

Changes:

 .tsd-navigation a,
 .tsd-page-navigation a {
     display: inline-flex;
     align-items: center;
-    padding: 0.25rem 0;
+    padding: 0.25rem;
     color: var(--color-text);
     text-decoration: none;
+    box-sizing: border-box;
 }
@RunDevelopment RunDevelopment added the enhancement Improved functionality label Apr 9, 2023
@Gerrit0 Gerrit0 added help wanted Contributions are especially encouraged good first issue Easier issue for first time contributors labels Apr 9, 2023
@Gerrit0 Gerrit0 added this to the v0.24.2 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved functionality good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged
Projects
None yet
Development

No branches or pull requests

2 participants