Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight type parameters consistently #2230

Closed
RunDevelopment opened this issue Apr 9, 2023 · 1 comment
Closed

Highlight type parameters consistently #2230

RunDevelopment opened this issue Apr 9, 2023 · 1 comment
Labels
enhancement Improved functionality
Milestone

Comments

@RunDevelopment
Copy link
Contributor

Search Terms

generic type parameters, semantic highlighting

Problem

I expected type parameters to have the same highlighting everywhere, but their highlighting is inconsistent. Type parameters are currently highlighted where they are defined and nowhere else. (This is only the case on class and interface pages. Type parameters are not highlighted at all in other pages. This is likely related to #2227.)

image

Suggested Solution

I have two main thoughts on this:

  1. Highlighting type parameters everywhere would be useful, because they are very important.
  2. Currently, only linked identifiers are highlighted. So highlighting type parameters without linking them would be inconsistent.

So I would suggest to either remove highlighting for type parameters everywhere, or to highlight them everywhere and add links for them. If consistency is not as important (e.g. because more highlighting is planned in the future, idk), then I think that type parameters should be highlighted everywhere, even without them linking to anything. Depends on what is more important.

@RunDevelopment RunDevelopment added the enhancement Improved functionality label Apr 9, 2023
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 9, 2023

Currently type parameters are never linked, and are actually created intentionally broken for some reason that I don't remember right now (possibly carry-over hacks from when the themes were in handlebars and I was terrified of changing the model due to no type checking?)

@Gerrit0 Gerrit0 added this to the v0.24.2 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved functionality
Projects
None yet
Development

No branches or pull requests

2 participants