Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search) Show a no results placeholder when no results are available #2347

Merged
merged 1 commit into from Jul 29, 2023

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jul 25, 2023

  • Adds placeholder text ("No Results Found") when no search results are available.

Note: this result does not have a hover state as there are no actions that can be taken with it

Before:

Screenshot 2023-07-25 at 09 50 49

After:

Screenshot 2023-07-25 at 09 49 48

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jul 29, 2023

This is awesome, thank you!

@Gerrit0 Gerrit0 merged commit 69d683b into TypeStrong:master Jul 29, 2023
5 checks passed
@camc314 camc314 deleted the cam/dev/no-results branch December 30, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants