Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch mode not working after upgrade to 0.25.0 #2378

Closed
HemalPatil opened this issue Aug 28, 2023 · 1 comment · Fixed by #2379
Closed

Watch mode not working after upgrade to 0.25.0 #2378

HemalPatil opened this issue Aug 28, 2023 · 1 comment · Fixed by #2379
Labels
bug Functionality does not match expectation

Comments

@HemalPatil
Copy link
Contributor

Search terms

Watch mode

Expected Behavior

Use TypeScript's incremental compiler to watch source files for changes and build the docs on change.

Actual Behavior

Does not create docs in the watch mode and exits prematurely.

Steps to reproduce the bug

  1. Upgraded to typedoc@0.25.0 to allow support for typescript@5.2.2.
  2. Checkout https://github.com/HemalPatil/td-bug
  3. Do npm install and then npm run watch:docs.
  4. Expected to see docs generated in watch mode like it did with typedoc@0.24.8.
  5. If you change the typedoc version back to 0.24.8 in the package.json in sample repo and install the dependencies (may have to do force install because of missing typescript peer dependency), this feature works fine.

Have the configs for watch mode changed? Seems unlikely after reading the official TypeDoc docs.

Environment

  • Typedoc version: 0.25.0
  • TypeScript version: 5.2.2
  • Node.js version: 18.17.1
  • OS: Ubuntu 22.04 and MacOS 13
@HemalPatil HemalPatil added the bug Functionality does not match expectation label Aug 28, 2023
@HemalPatil
Copy link
Contributor Author

Looks like the bug was introduced in the commit Support ESM config files

HemalPatil added a commit to HemalPatil/typedoc that referenced this issue Aug 28, 2023
@HemalPatil
Do not exit when in watch mode
cbdd063 
Resolves TypeStrong#2378
@HemalPatil HemalPatil mentioned this issue Aug 28, 2023
Merged
HemalPatil added a commit to HemalPatil/typedoc that referenced this issue Aug 29, 2023
@HemalPatil
Do not exit when in watch mode
55f9979 
Resolves TypeStrong#2378
Gerrit0 pushed a commit that referenced this issue Sep 3, 2023
@HemalPatil
Do not exit when in watch mode (#2379)
b367539 
Resolves #2378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Functionality does not match expectation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not exit when in watch mode HemalPatil/typedoc
1 participant
@HemalPatil