Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to resolve links after update #2403

Closed
weboko opened this issue Sep 19, 2023 · 3 comments
Closed

Failing to resolve links after update #2403

weboko opened this issue Sep 19, 2023 · 3 comments
Labels
bug Functionality does not match expectation

Comments

@weboko
Copy link

weboko commented Sep 19, 2023

Search terms

monorepo
failed to resolve links
resolve

Question

I am migrating from typedoc: 0.23.26 + typedoc-plugin-resolve-crossmodule-references: 0.3.3 to typedoc: 0.25.1
And it seems I hit some interesting case when links are failing to get resolved

image

It is a monorepo and has the following package structure:

packages
├── build-utils
├── core
├── dns-discovery
├── enr
├── interfaces
├── message-encryption
├── message-hash
├── peer-exchange
├── proto
├── relay
├── sdk
├── tests
└── utils

Here is typedoc.cjs I am using - link
To me it seems a bit similar to #2360

I am wondering if it can be realted to how plugin + legacy-packages were working together before or due to my bad with configuring typedoc.

Appreciate you help!

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Sep 23, 2023

Those warnings are supposed to be disabled until the final merging converted projects step... not entirely sure why I did the override before reading options instead of after.

// Invalid links should only be reported after everything has been merged.
opts.setValue("validation", { invalidLink: false });
await opts.read(this.logger, dir);

Assuming you didn't get warnings in the merge step, the links aren't actually broken, they're just broken in the intermediate step before all packages have been converted.

@Gerrit0 Gerrit0 added the bug Functionality does not match expectation label Sep 23, 2023
@weboko
Copy link
Author

weboko commented Oct 2, 2023

@Gerrit0 thank you for giving it a look

@Dayday10
Copy link

Dayday10 commented Oct 6, 2023

Can you double-check this for me Thank you

@Gerrit0 Gerrit0 removed the question Question about functionality label Oct 6, 2023
@Gerrit0 Gerrit0 closed this as completed in 2cabd22 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

3 participants