Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front-end Settings checkbox never checked #2408

Closed
hasezoey opened this issue Oct 5, 2023 · 2 comments
Closed

front-end Settings checkbox never checked #2408

hasezoey opened this issue Oct 5, 2023 · 2 comments
Labels
bug Functionality does not match expectation

Comments

@hasezoey
Copy link

hasezoey commented Oct 5, 2023

Search terms

front-end
settings
checkbox

Expected Behavior

I expect the checkboxes under Settings to display something different than when not checked

Actual Behavior

Currently the settings checkboxes stay the same, regardless if active or not

Steps to reproduce the bug

open some typedoc site (using 0.25.1) and try to use the settings

Environment

  • Typedoc version: 0.25.1
  • TypeScript version: 5.0.4
  • Node.js version: 20.5.1
  • OS: Linux Manjaro 23.0.2

additional context:
this problem goes away when downgrading to 0.24.8

also when using darkreader (it is disabled for the above issues), those checkboxes (and some other svgs) are a problem, see darkreader/darkreader#11786, the old website design worked fine (like 0.22)

@hasezoey hasezoey added the bug Functionality does not match expectation label Oct 5, 2023
@Gerrit0 Gerrit0 closed this as completed in 878e06a Oct 6, 2023
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Oct 6, 2023

Oops..

Darkreader seems like it ought not even activate on TypeDoc's pages... by default, the theme natively respects the browser's color scheme preferences.

@hasezoey
Copy link
Author

hasezoey commented Oct 6, 2023

Darkreader seems like it ought not even activate on TypeDoc's pages... by default, the theme natively respects the browser's color scheme preferences.

i have it active by default and used it when there was no theme settings, also i personally prefer black-gray-ish rather than blue-ish dark (at least on my screen), just wanted to mention it here, because the issue (at least visually) looked similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

2 participants