New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship barebone typings. #137

Closed

SimonSchick opened this issue Aug 6, 2018 · 2 comments

Contributor

SimonSchick commented Aug 6, 2018

Ironically this package doesn't seem to be shipping it's typings, could they be added?

Member

johnnyreilly commented Aug 7, 2018

Sure - would you like to send a PR? You probably just need to make same changes we made for ts-loader; see https://github.com/TypeStrong/ts-loader/blob/master/src/tsconfig.json and https://github.com/TypeStrong/ts-loader/blob/master/package.json

Also TypeStrong/ts-loader#790 and TypeStrong/ts-loader#788

cc @Hotell in case he's any advice

johnnyreilly mentioned this issue

Add types to the plugin (fixes #137) and prepare 0.4.5 release #139

Merged

johnnyreilly closed this as completed in

45dc15a

Member

johnnyreilly commented Aug 8, 2018

Shipped with 0.4.5 https://github.com/Realytics/fork-ts-checker-webpack-plugin/releases/tag/0.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment