New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing peer dependencies #507
Conversation
Code Climate has analyzed commit 152cc22 and detected 0 issues on this pull request. View more on Code Climate. |
@piotr-oles could you please look into this issue? I've stumbled upon the fact that |
pnpm workaroundIf you are using pnpm, you can temporarily fix this problem using the following module.exports = {
hooks: { readPackage },
};
function readPackage($package, context) {
if ($package.name === 'fork-ts-checker-webpack-plugin') {
$package.peerDependencies.webpack = '^5.0.0';
}
return $package;
} |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@piotr-oles What's status of this PR? The latest comment was that it would produce unwanted warnings, however this is not the case since all major package managers support I would be happy to create a new PR that specifically targets |
I think we can merge this to the main branch if it's well supported :) |
@piotr-oles Awesome! Looks like it just needs to be approved. |
This is a followup to TypeStrong#507. I'm guessing CRA would want all of the peer dependencies optional not just some of them. I could be mistaken, but I don't want the previous PR to cause any problems for CRA.
🎉 This PR is included in version 6.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
TypeStrong/fork-ts-checker-webpack-plugin#507 has been merged and released.
🎉 This PR is included in version 7.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What's the problem this PR addresses?
fork-ts-checker-webpack-plugin
depends on some peer dependencies without declaring them as such, this makes it rely on hoisting to place the dependencies in an accessible location which is not guaranteed to happen.How did you fix it?
Declare
typescript
andwebpack
as peer dependencies andvue-template-compiler
andeslint
as an optional peer dependency