Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob pattern string required #594

Closed
tcastelly opened this issue Apr 21, 2021 · 5 comments · Fixed by #595
Closed

glob pattern string required #594

tcastelly opened this issue Apr 21, 2021 · 5 comments · Fixed by #595

Comments

@tcastelly
Copy link

Hi,

Current behavior

After update to v6.2.1 I can't start anymore a VueJS project.

TypeError: glob pattern string required
    at Object.minimatch [as default] (/home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/minimatch/minimatch.js:94:11)
    at /home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/fork-ts-checker-webpack-plugin/lib/watch/InclusiveNodeWatchFileSystem.js:15:40
    at /home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/fork-ts-checker-webpack-plugin/lib/watch/InclusiveNodeWatchFileSystem.js:18:59
    at Array.some (<anonymous>)
    at isIgnored (/home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/fork-ts-checker-webpack-plugin/lib/watch/InclusiveNodeWatchFileSystem.js:18:33)
    at /home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/fork-ts-checker-webpack-plugin/lib/watch/InclusiveNodeWatchFileSystem.js:53:90
    at Array.filter (<anonymous>)
    at InclusiveNodeWatchFileSystem.watch (/home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/fork-ts-checker-webpack-plugin/lib/watch/InclusiveNodeWatchFileSystem.js:53:38)
    at Watching.watch (/home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/webpack/lib/Watching.js:114:48)
    at /home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/webpack/lib/Watching.js:101:10
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:80:1)
    at AsyncSeriesHook.lazyCompileHook (/home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/tapable/lib/Hook.js:154:20)
    at Watching._done (/home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/webpack/lib/Watching.js:98:28)
    at /home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/webpack/lib/Watching.js:73:19
    at Compiler.emitRecords (/home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/webpack/lib/Compiler.js:499:39)
    at /home/tcy/documents/dev/workspaces/minimatch-bug/node_modules/webpack/lib/Watching.js:54:20

Steps to reproduce the issue

Environment

  • fork-ts-checker-webpack-plugin: 6.1.2
  • typescript: 4.2.4
  • eslint: 7.24.0
  • webpack: 4.0.0
  • os: Gnu Linux / ArchLinux
@tcastelly tcastelly added the bug label Apr 21, 2021
@piotr-oles
Copy link
Collaborator

Thanks for reporting that, I think I know where the issue is :) As a temporary workaround, please try to overwrite watchOptions.ignored field in webpack config to /node_modules/.

@piotr-oles
Copy link
Collaborator

It looks like vue is passing ignored: {} which seems wrong according to the webpack documentation, but I will create an additional check to handle such a case :)

@piotr-oles
Copy link
Collaborator

🎉 This issue has been resolved in version 6.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tcastelly
Copy link
Author

It works, thank you very much! :)

@piotr-oles
Copy link
Collaborator

🎉 This issue has been resolved in version 7.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants