Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use caches for module resolution and type reference directives when using compiler default functions #598

Closed
johnnyreilly opened this issue Apr 22, 2021 · 2 comments

Comments

@johnnyreilly
Copy link
Member

johnnyreilly commented Apr 22, 2021

Hey @piotr-oles

I just wanted to give you a heads up as to this feature being added by @sheetalkamat to ts-loader:

TypeStrong/ts-loader#1287

Is it possible that some of this could be useful for fork-ts-checker-webpack-plugin?

@piotr-oles
Copy link
Collaborator

Hmmm... If I understand correctly, the compiler host created by ts.createCompilerHost() or ts.createWatchCompilerHost() has built-in cache for resolveModuleNames() and resolveTypeReferenceDirectives() but if you overwrite these methods, you will lost the cache mechanism. If that's the case, it will not improve the performance of this plugin, because we don't overwrite these methods :)

@johnnyreilly
Copy link
Member Author

Ah well - good to check though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants