fix: compiler crashes are not handled #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-oles
force-pushed
the
bugfix/handle_compiler_crashes
branch
from
94c5c02
to
a6c2042
Compare
|
🎉 This PR is included in version 9.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added handling of compiler crashes. At the current state, the plugin ignores general compiler failures. In our case, it was "RangeError: Maximum call stack size exceeded" caused by the allowJs compiler option. Plugin just ignored this issue, so we didn't notice that is something wrong with our typescript config and now we need to fix type errors for the last 2 months.