Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Compiler Errors when using Typescript Project References #1087

Closed
berickson1 opened this issue Apr 13, 2020 · 2 comments
Closed

Missing Compiler Errors when using Typescript Project References #1087

berickson1 opened this issue Apr 13, 2020 · 2 comments

Comments

@berickson1
Copy link
Contributor

Expected Behaviour

ts-loader warns about all typescript compiler errors on first run

Actual Behaviour

errors for composite projects are ignored when re-running webpack

Steps to Reproduce the Problem

  1. Have a working & building typescript project that uses composite projects
  2. Stop webpack
  3. Introduce a compiler error into one of the composite projects
  4. Run Webpack

At this point I'd expect an error, but the build reports as successful and emits without issue

Location of a Minimal Repository that Demonstrates the Issue.

https://github.com/berickson1/project-references-demo

For the above:

  1. run npm install
  2. run npm run webpack
  3. observe successful build
  4. stop webpack
  5. Open animals/dog.ts and uncomment line 15 to introduce a compiler error
  6. run npm run webpack
  7. Observe "successful" build

Note: I turned on ts-loader logging and you can see that the error is being reported during the typescript build process, but it doesn't bubble up to webpack

@johnnyreilly
Copy link
Member

This will hopefully be remedied by the excellent work @sheetalkamat is doing in #1076

@berickson1
Copy link
Contributor Author

Looks like it did! I'm happy to report that this no longer repros on ts-loader@7.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants