Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build bug with new version #931

Closed
Frozenfire92 opened this issue May 7, 2019 · 2 comments
Closed

build bug with new version #931

Frozenfire92 opened this issue May 7, 2019 · 2 comments

Comments

@Frozenfire92
Copy link

Frozenfire92 commented May 7, 2019

Expected Behaviour

it builds properly

Actual Behaviour

it fails with this warning

./cypress/integration/bugtest/example.spec.ts
Module build failed (from ./node_modules/ts-loader/index.js):
/some_path/node_modules/ts-loader/node_modules/micromatch/index.js:44
    let isMatch = picomatch(String(patterns[i]), { ...options, onResult }, true);
                                                   ^^^

SyntaxError: Unexpected token ...

Steps to Reproduce the Problem

  • a new cypress project, try adding typescript like in their example
  • npm run cypress:open

If your ts-loader version is > 5.4.5 it will break. I confirmed switching to 5.4.5 it does not break

It appears to be caused by: https://github.com/TypeStrong/ts-loader/pull/928/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R57

and I see similar issues on other projects that may be realted: micromatch/micromatch#159 or BrowserSync/browser-sync#1682

@zoltanbedi
Copy link

see #929

@andrewbranch
Copy link
Contributor

Closing as duplicate of #929. Thanks @B3zo0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants