From 5ff14a29453a3b661ec24b6584afaac476f6579d Mon Sep 17 00:00:00 2001 From: gasnier Date: Sun, 25 Apr 2021 22:12:45 +0200 Subject: [PATCH 1/4] file can sometimes be undefined when using webpack devserver (with watch) --- src/after-compile.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/after-compile.ts b/src/after-compile.ts index c6e6a887c..55c9f93d2 100644 --- a/src/after-compile.ts +++ b/src/after-compile.ts @@ -184,7 +184,8 @@ function determineFilesToCheckForErrors( return filesToCheckForErrors; function addFileToCheckForErrors(filePath: FilePathKey, file: TSFile) { - if (!isReferencedFile(instance, filePath)) { + //file can sometimes be undefined when using webpack devserver + if (file && !isReferencedFile(instance, filePath)) { filesToCheckForErrors.set(filePath, file); } } From 58aed804b78d7d1ffefed8458811d77d4a7c9d4d Mon Sep 17 00:00:00 2001 From: gasnier Date: Sun, 25 Apr 2021 22:33:13 +0200 Subject: [PATCH 2/4] remove evil ! bypass... --- src/after-compile.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/after-compile.ts b/src/after-compile.ts index 55c9f93d2..c1568b874 100644 --- a/src/after-compile.ts +++ b/src/after-compile.ts @@ -170,7 +170,9 @@ function determineFilesToCheckForErrors( ).keys()) { const fileToCheckForErrors = files.get(fileName) || otherFiles.get(fileName); - addFileToCheckForErrors(fileName, fileToCheckForErrors!); + if (fileToCheckForErrors) {//file may have been removed + addFileToCheckForErrors(fileName, fileToCheckForErrors); + } } } } From 2906b46e87b37a290dc6a04acec9002045c895c1 Mon Sep 17 00:00:00 2001 From: gasnier Date: Sun, 25 Apr 2021 22:35:33 +0200 Subject: [PATCH 3/4] comment is no more needed --- src/after-compile.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/after-compile.ts b/src/after-compile.ts index c1568b874..99cb9f37b 100644 --- a/src/after-compile.ts +++ b/src/after-compile.ts @@ -186,7 +186,6 @@ function determineFilesToCheckForErrors( return filesToCheckForErrors; function addFileToCheckForErrors(filePath: FilePathKey, file: TSFile) { - //file can sometimes be undefined when using webpack devserver if (file && !isReferencedFile(instance, filePath)) { filesToCheckForErrors.set(filePath, file); } From 97913a922a5dc7c1baac063f434eccbffc6fa224 Mon Sep 17 00:00:00 2001 From: gasnier Date: Wed, 5 May 2021 21:18:24 +0200 Subject: [PATCH 4/4] Bump version to 9.1.2 - Fix removed files handling in watch mode --- CHANGELOG.md | 4 ++++ package.json | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cc9619197..97c09f42b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## v9.1.2 + +* [Fix removed files handling in watch mode](https://github.com/TypeStrong/ts-loader/pull/1293) - thanks @gasnier + ## v9.1.1 * [update CHANGELOG.md for 8.2.0 release](https://github.com/TypeStrong/ts-loader/pull/1291) - thanks @johnnyreilly diff --git a/package.json b/package.json index 2c9cbb3ca..22c612375 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ts-loader", - "version": "9.1.1", + "version": "9.1.2", "description": "TypeScript loader for webpack", "main": "index.js", "types": "dist", @@ -101,4 +101,4 @@ "typescript": "*", "webpack": "*" } -} +} \ No newline at end of file