Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interactive flag so that it forces REPL even when stdin is not a tty #1019

Merged
merged 2 commits into from Apr 26, 2020
Merged

Fix interactive flag so that it forces REPL even when stdin is not a tty #1019

merged 2 commits into from Apr 26, 2020

Conversation

cspotcode
Copy link
Collaborator

Fixes #1013

There's a bug with the --interactive / -i flag where it does not launch the REPL when stdin is not a tty.

This fix makes our behavior match node's -i flag and our help docs.

@coveralls
Copy link

coveralls commented Apr 26, 2020 •
edited

Coverage Status

Coverage increased (+0.2%) to 80.088% when pulling 9bd86e8 on ab/fix-interactive-flag into 47a560b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.911% when pulling 6a32006 on ab/fix-interactive-flag into 47a560b on master.

@cspotcode cspotcode merged commit 9fee232 into master Apr 26, 2020
@cspotcode cspotcode mentioned this pull request Apr 26, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Open
@cspotcode cspotcode deleted the ab/fix-interactive-flag branch May 9, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeembrey blakeembrey blakeembrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts-node -i repl do not fflush stdout
3 participants
@cspotcode @coveralls @blakeembrey