Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Register to Service; re-export as Register for backwards… #1158

Merged
merged 3 commits into from Dec 3, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Nov 22, 2020

Based on conversation here: #1121 (comment)

create() will create a Service. register() will create and register it into the node runtime. But the object itself is not really a Register (noun), it's a Service which handles compilation.

Other names could be Compiler, TsNodeCompiler, or Compiler?

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #1158 (cee6007) into master (8b9489a) will decrease coverage by 0.26%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1158      +/-   ##
==========================================
- Coverage   79.60%   79.33%   -0.27%     
==========================================
  Files           7       11       +4     
  Lines         711      755      +44     
  Branches      158      157       -1     
==========================================
+ Hits          566      599      +33     
- Misses         89      101      +12     
+ Partials       56       55       -1     
Flag Coverage Δ
node_10 76.20% <75.00%> (+0.09%) ⬆️
node_12_15 76.55% <75.00%> (+0.09%) ⬆️
node_12_16 76.55% <75.00%> (+0.09%) ⬆️
node_13 78.67% <75.00%> (-0.23%) ⬇️
node_14 78.67% <75.00%> (-0.23%) ⬇️
node_14_13_0 77.88% <75.00%> (-0.18%) ⬇️
node_15 78.67% <75.00%> (-0.23%) ⬇️
typescript_2_7 78.67% <75.00%> (-0.23%) ⬇️
typescript_latest 77.88% <75.00%> (-0.18%) ⬇️
typescript_next 77.88% <75.00%> (-0.18%) ⬇️
ubuntu 78.54% <75.00%> (-0.22%) ⬇️
windows 78.67% <75.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 79.20% <66.66%> (+0.14%) ⬆️
src/bin.ts 79.19% <100.00%> (ø)
dist-raw/node-options.js 78.37% <0.00%> (-0.41%) ⬇️
dist-raw/node-errors.js 66.66% <0.00%> (ø)
dist-raw/node-package-json-reader.js 84.21% <0.00%> (ø)
dist-raw/node-internal-fs.js 75.00% <0.00%> (ø)
dist-raw/node-primordials.js 50.00% <0.00%> (ø)
dist-raw/node-cjs-loader-utils.js 83.67% <0.00%> (+3.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9489a...cee6007. Read the comment docs.

Copy link
Member

@blakeembrey blakeembrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

src/index.ts Outdated
@@ -1024,7 +1031,7 @@ function registerExtensions (
*/
function registerExtension (
ext: string,
register: Register,
register: Service,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename this variable too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants