Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible repl bug: not using DI-ed console #1217

Closed
cspotcode opened this issue Feb 13, 2021 · 0 comments · Fixed by #1224
Closed

Possible repl bug: not using DI-ed console #1217

cspotcode opened this issue Feb 13, 2021 · 0 comments · Fixed by #1224
Milestone
10.0.0

Comments

@cspotcode
Copy link
Collaborator

cspotcode commented Feb 13, 2021 •
edited

ts-node/src/repl.ts

Line 98 in 080af32

console.error(error)

Note to self to double-check this. I'm pretty sure it's a bug; should be using _console (the dependency-injected console) so that it respects API consumers which supply a custom console.
cspotcode added a commit that referenced this issue Feb 15, 2021
@cspotcode
fix #1217
764eb81
@cspotcode cspotcode mentioned this issue Feb 15, 2021
Merged
cspotcode added a commit that referenced this issue Feb 16, 2021
@cspotcode
fix #1217 (#1224)
7caba3b
@cspotcode cspotcode added this to the 10.0.0 milestone May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

fix #1217: repl not using DI-ed console for error logging TypeStrong/ts-node
1 participant
@cspotcode