Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1217: repl not using DI-ed console for error logging #1224

Merged
merged 2 commits into from Feb 16, 2021
Merged

fix #1217: repl not using DI-ed console for error logging #1224

merged 2 commits into from Feb 16, 2021

Conversation

cspotcode
Copy link
Collaborator

Fix #1217

@cspotcode cspotcode changed the title fix #1217 fix #1217: repl not using DI-ed console for error logging Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021 •
edited

Codecov Report

Merging #1224 (f7f11e7) into master (bacbeaf) will not change coverage.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
src/repl.ts 74.78% <0.00%> (ø)

@cspotcode cspotcode merged commit 7caba3b into master Feb 16, 2021
@cspotcode cspotcode added this to the 10.0.0 milestone May 15, 2021
@cspotcode cspotcode deleted the ab/repl-use-di-ed-console branch October 11, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

Possible repl bug: not using DI-ed console
1 participant
@cspotcode