Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document reason for TS 2.7 support, possibly increase minimum supported version #1316

Closed
cspotcode opened this issue May 15, 2021 · 5 comments
Labels
research Needs design work, investigation, or prototyping. Implementation uncertain.
Milestone

Comments

@cspotcode
Copy link
Collaborator

When I started working on ts-node, the readme said we supported TS 2.7 and the tests ran against TS 2.7, so I've maintained that support. But I don't actually know why we support that version. Enough time has passed, it may make sense to increase the minimum supported version.

@blakeembrey do you remember if there were any specific reasons for supporting 2.7? Was a high-profile project stuck on 2.7 at some point in the past?

A quick search turned up #527 but I don't know if it's related.

Some data points:

@cspotcode cspotcode added the research Needs design work, investigation, or prototyping. Implementation uncertain. label May 15, 2021
@cspotcode cspotcode added this to the 10.0.0 milestone May 15, 2021
@cspotcode
Copy link
Collaborator Author

cspotcode commented May 15, 2021

Or maybe ts-node added a feature that could not work on versions older than 2.7, and so it was documented that 2.7 was the minimum?

@blakeembrey
Copy link
Member

Yeah, if you need to upgrade in a major version don't restrict yourself! I don't really remember now, but going a git blame on that specific line in the README is pretty helpful for the history of the changes. Looks like I last bumped it from 2.0 -> 2.7 in #895 which was a minimum feature requirement.

@cspotcode
Copy link
Collaborator Author

Ok, thanks. Turns out it won't be necessary for v10, because I ended up re-adding @tsconfig/node10 to keep things simple. But this is good to know for v11.

@cspotcode cspotcode modified the milestones: 10.0.0, next May 16, 2021
@cspotcode
Copy link
Collaborator Author

Closing as answered.

@jhmaster2000
Copy link
Contributor

To future readers, as the milestone links above aren't very helpful to connect these together, the v11 plan relating to this issue is here: #1505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research Needs design work, investigation, or prototyping. Implementation uncertain.
Projects
None yet
Development

No branches or pull requests

3 participants