Detect esm builtins protocol change on node 12.20.0 #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ier-resolution=node tests
Codecov Report
|
cspotcode
force-pushed
the
ab/detect-esm-builtins-protocol-change-on-node-12_20_0
branch
from
11ab0bf
to
9ab0fb6
Compare
cspotcode
deleted the
ab/detect-esm-builtins-protocol-change-on-node-12_20_0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1331
Adds node 12.16 to the test matrix
Run ESM tests on node 12.16 and up; previously was skipping them on <13
Updates tests to pass
--experimental-moduleswhere demanded by old versions of nodeAdd native module test to
./tests/esm-node-resolverto match./tests/esm