Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to specify pretty errors in TTY #1420

Merged
merged 3 commits into from Aug 8, 2021

Conversation

elevatebart
Copy link
Contributor

closes #1418

@cspotcode
Copy link
Collaborator

cspotcode commented Aug 5, 2021

Looks good, did you test this? I don't think it needs automated tests but it would be nice to do some manual testing:

ts-node --pretty ./file-with-errors.ts > out.txt // <-- not a TTY but should still have pretty errors
ts-node ./file-with-errors.ts // <-- in a directory where pretty: false is specified in tsconfig.json

EDIT you already asked about testing here

@cspotcode cspotcode added this to the 10.x.x milestone Aug 5, 2021
@cspotcode
Copy link
Collaborator

Looks like this needs npm run lint-fix to fix linter failures.

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #1420 (e9c31b0) into main (dc0fed2) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
src/index.ts 77.80% <66.66%> (+0.05%) ⬆️

@cspotcode cspotcode merged commit b044e71 into TypeStrong:main Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pretty option is ignored in terminal
2 participants