Redirect source-map-support to @cspotcode/source-map-support #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
cspotcode
added a commit
that referenced
this pull request
Oct 11, 2021
…support (#1497) * Update package.json * update package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1441
Facilitated by cspotcode/node-source-map-support#23 and cspotcode/node-source-map-support#30
Uses the new redirection feature from
@cspotcode/source-map-supportto transparently redirect libraries that try to usesource-map-supportto instead use@cspotcode/source-map-supportThis seems like a dirty hack, and it is, but
@cspotcode/source-map-supportalso supports the better solution to this class of problem: cspotcode/node-source-map-support#28If anyone in the future is reading this, please keep in mind that we are only forced to do this because
source-map-supporthas not merged the corresponding PR to their repository.Thus we redirect the
require()and maintain API compatibility. Any third-party libraries that want to avoid this potential gotcha can upgrade to@cspotcode/source-map-support.