Downgrade to yn v3 to avoid v4's node 10 requirement #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
reviewed
Jan 13, 2020
src/index.ts
Outdated
| */ | ||
| function yn (value: string | undefined) { | ||
| const parsed = ynModule(value) | ||
| return parsed === null ? undefined : parsed |
There was a problem hiding this comment.
We could also just use nullish coalescing within the DEFAULTS object nowadays.
There was a problem hiding this comment.
Yeah good point. Even using ??, it's a bit more DRY to keep it within this helper function, and it matches the API of yn v4. Do you still want to get rid of the helper function and move it all to the DEFAULTS object literal?
|
Thank you so much @cspotcode & @blakeembrey! |
This was referenced Feb 5, 2020
This was referenced Mar 18, 2020
This was referenced Mar 25, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940