Fix bash error in usage example on README page #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux bash terminal, executing
`echo "console.log('Hello, world!')"`
gives the following error:
`bash: !': event not found`
To fix the issue, changing the log string from
`Hello, world!` to `Hello, world`
Tested on following systems:
* Ubuntu 18.04.3 LTS
* Linux Mint 19
|
@abraj Good catch, thanks. Can you think of any problems with switching the quotes around to keep the exclamation mark? |
Switching the quotes around in the line
`echo "console.log('Hello, world!')" | ts-node`
to get the line as
`echo 'console.log("Hello, world!")' | ts-node`
in order to keep the exclamation mark, while also
avoiding the bash error at the same time.
|
@cspotcode Even better! I think that switching the quotes should be the way to go. |
This was referenced Mar 18, 2020
This was referenced Mar 25, 2020
This was referenced Apr 12, 2020
This was referenced Apr 13, 2020
This was referenced Apr 21, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux bash terminal, executing
echo "console.log('Hello, world!')"gives the following error:
bash: !': event not foundTo fix the issue, changing the log string from
Hello, world!toHello, worldTested on following systems: