Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for mocha 7, since they removed some watch flags in v7 #961

Merged
merged 3 commits into from Mar 2, 2020

Conversation

cspotcode
Copy link
Collaborator

This adds a mocha example that works for mocha 7.

They removed the --watch-extensions flag in v7.
https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#700--2020-01-05

I asked in #266 if anyone's able to test it, since I don't use mocha's watch mode on any of my projects.

@coveralls
Copy link

coveralls commented Feb 16, 2020

Coverage Status

Coverage increased (+0.4%) to 79.231% when pulling eb6d493 on ab/fix-mocha-example into 3eb46e0 on master.

README.md Outdated
```sh
mocha --require ts-node/register --extensions ts,tsx --watch --watch-files src 'tests/**/*.{ts,tsx}' [...args]
```

**Note:** `--watch-extensions` is only used in `--watch` mode.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the note back below mocha 6 or delete it?

@cspotcode cspotcode merged commit e006df6 into master Mar 2, 2020
@cspotcode cspotcode moved this from In Review to Merged to master in Andrew Bradley's Tasks Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Andrew Bradley's Tasks
Merged to master
Development

Successfully merging this pull request may close these issues.

None yet

3 participants