Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change order of npm installation #993

Merged
merged 1 commit into from Apr 7, 2020
Merged

change order of npm installation #993

merged 1 commit into from Apr 7, 2020

Conversation

jacobdcastro
Copy link
Contributor

After attempting to copy/paste local installs, I hit an error. ts-node requires a peer dependency of typescript. Therefore, I had to install typescript before ts-node for it successfully install. It makes sense to order these appropriately in the README.

After attempting to copy/paste local installs, I hit an error. ts-node requires a peer dependency of typescript. Therefore, I had to install typescript before ts-node for it to work. It makes sense to order these appropriately in the README.
@cspotcode
Copy link
Collaborator

Interesting, I thought yarn was the only one that threw an error when you omit a peerDependency.
Does npm outright disallow this, or merely log a warning?

@jacobdcastro
Copy link
Contributor Author

It gave me an error outright and didn't install ts-node at all until I installed typecript. I attempted twice with the same result before installing typescript first.

Although, just a minute ago I tried again and worked fine. Possible random glitch earlier.

@cspotcode
Copy link
Collaborator

image

@blakeembrey
Copy link
Member

Feel free to merge either way, seems like it wouldn't hurt 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants