From 4067f2c838255c4d8cba13bb743172b9f4c2a978 Mon Sep 17 00:00:00 2001 From: Nickolay Platonov Date: Sat, 25 Apr 2020 21:10:29 +0300 Subject: [PATCH] fix: Do not silently swallow missing include/media file errors (#1277) --- src/lib/output/plugins/MarkedPlugin.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lib/output/plugins/MarkedPlugin.ts b/src/lib/output/plugins/MarkedPlugin.ts index 48b57bf3f..08715f7bf 100644 --- a/src/lib/output/plugins/MarkedPlugin.ts +++ b/src/lib/output/plugins/MarkedPlugin.ts @@ -135,6 +135,7 @@ export class MarkedPlugin extends ContextAwareRendererComponent { return contents; } } else { + this.application.logger.warn('Could not find file to include: ' + path); return ''; } }); @@ -142,9 +143,12 @@ export class MarkedPlugin extends ContextAwareRendererComponent { if (this.mediaDirectory) { text = text.replace(this.mediaPattern, (match: string, path: string) => { - if (FS.existsSync(Path.join(this.mediaDirectory!, path))) { + const fileName = Path.join(this.mediaDirectory!, path); + + if (FS.existsSync(fileName) && FS.statSync(fileName).isFile()) { return this.getRelativeUrl('media') + '/' + path; } else { + this.application.logger.warn('Could not find media file: ' + fileName); return match; } });