diff --git a/CHANGELOG.md b/CHANGELOG.md index 69dce4d4f..41c2d3298 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ### Bug Fixes - Readme files within monorepos now have `@link` tags resolved, #2029. +- Correctly resolve unqualified links to class members within parameters, #2031. ## v0.23.10 (2022-07-31) diff --git a/src/lib/converter/comments/declarationReferenceResolver.ts b/src/lib/converter/comments/declarationReferenceResolver.ts index 9184e4540..f235472ba 100644 --- a/src/lib/converter/comments/declarationReferenceResolver.ts +++ b/src/lib/converter/comments/declarationReferenceResolver.ts @@ -42,6 +42,8 @@ export function resolveDeclarationReference( refl = refl.parent; if (refl.kindOf(ReflectionKind.ExportContainer)) { high.push(refl); + } else { + low.push(refl); } } diff --git a/src/test/converter2/issues/gh2031.ts b/src/test/converter2/issues/gh2031.ts new file mode 100644 index 000000000..94e4c0678 --- /dev/null +++ b/src/test/converter2/issues/gh2031.ts @@ -0,0 +1,10 @@ +export class MyClass { + /** + * {@link anotherMethod} + * + * @param aParam {@link anotherMethod} + */ + aMethod(aParam: number) {} + + anotherMethod() {} +} diff --git a/src/test/issueTests.ts b/src/test/issueTests.ts index a58432c9b..c70ec6b2c 100644 --- a/src/test/issueTests.ts +++ b/src/test/issueTests.ts @@ -712,4 +712,18 @@ export const issueTests: { "Desc3" ); }, + + gh2031(project, logger) { + const sig = query(project, "MyClass.aMethod").signatures![0]; + const summaryLink = sig.comment?.summary[0]; + ok(summaryLink?.kind === "inline-tag"); + ok(summaryLink.target); + + const paramLink = sig.parameters![0].comment?.summary[0]; + ok(paramLink?.kind === "inline-tag"); + ok(paramLink.target); + + logger.discardDebugMessages(); + logger.expectNoOtherMessages(); + }, };