Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when have interface which inherit from multiple interfaces, we get only the first in result. #1579

Closed
nisimjoseph opened this issue Apr 26, 2021 · 4 comments · Fixed by redpeacock78/cie.js#6
Labels
bug Functionality does not match expectation

Comments

@nisimjoseph
Copy link

nisimjoseph commented Apr 26, 2021

Search terms

multiple interfaces extends

Expected Behavior

the export doc need to show all the interfaces which the new interface derived from when using Partial<> for the interfaces.

Actual Behavior

see all extends, it see only the first.

Steps to reproduce the bug

  1. add to file:
interface Shape extends Partial<BaseShape1>, Partial<BaseShape2> {}
  1. run typedoc and you will see only the "BaseShape1" interface included in the doc.

Environment

  • Typedoc version: 0.20.36
  • TypeScript version: 4.x
  • Node.js version: 14.16.x
  • OS: MAC
@nisimjoseph nisimjoseph added the bug Functionality does not match expectation label Apr 26, 2021
@krisztianb
Copy link
Contributor

What is BaseShape1?

@Gerrit0 Gerrit0 added reproduced good first issue Easier issue for first time contributors labels Apr 27, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 27, 2021

This is a bug in ReferenceType.equals. Currently it only checks the type name. It should also check that the type args are equal.

@Gerrit0 Gerrit0 added this to To do in Version 0.21 via automation Apr 27, 2021
@krisztianb
Copy link
Contributor

It doesn't check the name or am I mistaken? It checks if the references point to the same object.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Apr 27, 2021

It effectively checks the name by checking the pointed-to symbol. The name might be different even if the symbol is the same due to import aliases.

@Gerrit0 Gerrit0 moved this from To do to In progress in Version 0.21 May 1, 2021
@Gerrit0 Gerrit0 removed the good first issue Easier issue for first time contributors label May 1, 2021
@Gerrit0 Gerrit0 moved this from In progress to Done in Version 0.21 May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants