Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tokens are not displayed in story-book if there is only a category name. #121

Open
SmoliyY opened this issue Aug 17, 2022 · 4 comments
Labels
bug Something isn't working quick win

Comments

@SmoliyY
Copy link

SmoliyY commented Aug 17, 2022

Version

storybook-design-token: 2.6.0

Steps to Reproduce

Create basic storybook with next design-tokens. Example:

:root {
  /**
  * @tokens Animations
  * @presenter Animation
  */

  --animation-rotate: rotate 1.2s infinite cubic-bezier(0.55, 0, 0.1, 1);

  /**
  * @tokens Colors
  * @presenter Color
  */

  --b100: hsl(240, 100%, 90%); /* Token Description Example  @presenter Color */
  --b200: hsl(240, 100%, 80%);
  --b300: hsl(240, 100%, 70%);

  /**
  * @tokens Others
  */
  --border-normal: 3px dashed red; /* Token Description Example @presenter BorderRadius */
}

Current Behavior

Animations and Colors sections displayed as expected, but not Others.
Screenshot 2022-08-17 at 18 49 43

Expected Behavior

Others section should be displayed with appropriate @presenter BorderRadius preview.

@Sqrrl
Copy link
Collaborator

Sqrrl commented Sep 16, 2022

Hey, I'll look into it. Passing an empty presenter should help as a workaround.

@Sqrrl Sqrrl added bug Something isn't working quick win labels Sep 23, 2022
@abhiofficial66
Copy link

@Sqrrl I am also running into same issue and passing an empty presenter doesn't work for me. Do you have an example?

@Sqrrl
Copy link
Collaborator

Sqrrl commented Dec 19, 2022

Could you check v2.8.2? I've fixed an issue that might have been related.

@daphne
Copy link

daphne commented Dec 20, 2022

@Sqrrl it does work as expected on v2.8.2. Thank you for your quick respons 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quick win
Projects
None yet
Development

No branches or pull requests

4 participants