Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens source JSON not generated for published storybook #127

Open
Smolations opened this issue Sep 27, 2022 · 1 comment
Open

Tokens source JSON not generated for published storybook #127

Smolations opened this issue Sep 27, 2022 · 1 comment

Comments

@Smolations
Copy link

Once I deployed my changes where your addon is upgraded and in storybook v6.5.9, I was unable to view the standalone MDX documentation I created for my tokens. It works fine in dev, but when i build storybook to be deployed, there is no design-tokens.source.json artifact in my dist/storybook/ directory and I receive a 404 on the request at the deployed location. Is this call always meant to be external? Should the bundle be providing the file on that request? 🤔

@Smolations
Copy link
Author

Smolations commented Sep 27, 2022

Ok so, digging into this, I'm not sure if it's something you need to change or something the storybook team should change. It turns out that passing --quiet to the build-storybook command suppresses the generation of that design token file. It definitely shouldn't, but it does. At least now you're aware, and you can close this issue if you think it's not an issue with your addon. 😁

// package.json

"build:storybook": "build-storybook --quiet -o ./dist/storybook", // DOESN'T GENERATE FILE

"build:storybook": "build-storybook -o ./dist/storybook", // WORKS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant