Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message accessibility text #2861

Open
Elshara opened this issue Oct 10, 2022 · 2 comments
Open

Improve message accessibility text #2861

Elshara opened this issue Oct 10, 2022 · 2 comments

Comments

@Elshara
Copy link

Elshara commented Oct 10, 2022

Describe the bug
I'm not sure if this is a coding issue or just an oversight, but the way in which messages read in Unigram is messy.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'someone's conversation history'
  2. Look for 'extra periods and spaces in system messages'
  3. Where quotes and colons ought to be, there aren't any 'see template below'
  4. I've noticed this since version 8.

Expected behavior
System messages should be better formatted.
The following is a template used by the current format. This is exactly how a screen reader would read this out.
Name.
Replying to Person.
message, Received at ‎1‎:‎00‎ ‎PM. . check box not checked
Person.
Message, Received at ‎9‎:‎38‎ ‎AM. . check box not checked
Message, Sent at ‎5‎:‎27‎ ‎PM. Seen. check box not checked
Message, edited, Received at ‎3‎:‎19‎ ‎PM. . check box not checked
A better format would look like this.
Reply by Name to Person:
"message"
Received today, Monday, 10 October, 2022, 4 hours ago at 1:00 PM View Message Actions Menu, Alt + A
Person Said:
'Message'
Received today, Monday, 10 October, 2022, 8 hours ago at 9:38 AM View Message Actions Menu Alt + A
From Me:
'Message'
Sent yesterday on Sunday, 9 October, 2022, a day ago at 5:27 PM
Seen by X View Message Actions Menu Alt + A contains 2 replys and 1 reaction...
Person Said:
'Message'
Received yesterday, Sunday, 9 October 2022, a day ago at 3:19 PM
Last Edited by Person a day ago View Message Actions Menu Alt + A

Screenshots
It's just text based for accessibility and better readability reasons.

Version Info

  • Unigram: [9]
  • Windows: [11 enterprise 25217]

Additional context
This will make for a more smooth reading and interacting experience.

@FrayxRulez FrayxRulez changed the title Improve Message Text Format Improve message accessibility text Oct 17, 2022
@OSadovy
Copy link

OSadovy commented Dec 14, 2022

I think this is too verbose. Consider reading a chat consisting of hundreds of messages, and hearing "Somebody said" each time before the actual message. That would slow down the process and annoy the listener. If one gets into the list of chat messages, they are already aware that each message represents what somebody "said", so no need to duplicate that info each time.

@amirmahdifard
Copy link

oh no, this is crazy worbose: i just agree that it should say the amount of a replys a message has at the end, but so short, like, 4 replys: and i disagree wityh everything else on this tikit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants