TickBitmap, SwapMath, Oracle: replace "if (A && B)" to save gas fees

[BurtonQin]

The solidity compiler generates more code for “if (A && B) {}” than for “if (A) {if (B) {} }”.
Our experiment shows that switching from “if (A && B) {}” to “if (A) {if (B) {} }” can save gas fee.

There are six such cases:

v3-core/contracts/libraries/TickBitmap.sol

Line 49 in d8b1c63

if (tick < 0 && tick % tickSpacing != 0) compressed--; // round towards negative infinity

v3-core/contracts/libraries/SwapMath.sol

Line 87 in d8b1c63

if (!exactIn && amountOut > uint256(-amountRemaining)) {

v3-core/contracts/libraries/SwapMath.sol

Line 91 in d8b1c63

if (exactIn && sqrtRatioNextX96 != sqrtRatioTargetX96) {

v3-core/contracts/libraries/Oracle.sol

Line 93 in d8b1c63

if (cardinalityNext > cardinality && index == (cardinality - 1)) {

v3-core/contracts/libraries/Oracle.sol

Line 134 in d8b1c63

if (a <= time && b <= time) return a <= b;

v3-core/contracts/libraries/Oracle.sol

Line 179 in d8b1c63

if (targetAtOrAfter && lte(time, target, atOrAfter.blockTimestamp)) break;

Replacing

if (targetAtOrAfter && lte(time, target, atOrAfter.blockTimestamp)) break;

with

if (targetAtOrAfter) {
    if (lte(time, target, atOrAfter.blockTimestamp)) {
         break;
    }
}

can save gas fees and does not hurt readability.