Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gracefully handle unsuccessful metrics post #414

Merged
merged 5 commits into from
Jan 17, 2023
Merged

feat: gracefully handle unsuccessful metrics post #414

merged 5 commits into from
Jan 17, 2023
+149 −78

Conversation

ivarconr
Copy link
Member

fixes: #405

@coveralls
Copy link

coveralls commented Jan 16, 2023 •
edited
Loading

Coverage Status

Coverage: 92.01% (-0.09%) from 92.105% when pulling a1497ba on feat/gracefully-handle-metrics-post-error into 2893895 on main.

@coveralls
Copy link

Coverage Status

Coverage: 92.034% (-0.06%) from 92.093% when pulling 0139bf7 on feat/gracefully-handle-metrics-post-error into 1f72988 on main.

@ivarconr ivarconr requested review from chriswk and sighphyre January 16, 2023 20:59
@ivarconr ivarconr mentioned this pull request Jan 16, 2023
Merged
@ivarconr ivarconr requested a review from gardleopard January 17, 2023 08:27
gardleopard
gardleopard approved these changes Jan 17, 2023
View reviewed changes
Copy link

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sighphyre
sighphyre approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've left a few thoughts but I don't think anything is deal breaking

@ivarconr ivarconr force-pushed the feat/gracefully-handle-metrics-post-error branch from 0139bf7 to e5532bf Compare January 17, 2023 19:58
@ivarconr ivarconr merged commit e4c2963 into main Jan 17, 2023
@ivarconr ivarconr deleted the feat/gracefully-handle-metrics-post-error branch January 17, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardleopard gardleopard

@sighphyre sighphyre

@chriswk chriswk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: resend metrics at next interval if it fails
4 participants
@ivarconr @coveralls @gardleopard @sighphyre