Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve Database SSL option section #1445

Closed
ivarconr opened this issue Mar 16, 2022 · 0 comments
Closed

docs: Improve Database SSL option section #1445

ivarconr opened this issue Mar 16, 2022 · 0 comments
Assignees

Comments

@ivarconr
Copy link
Member

Today we get a few question every now and then about SSL options for the database connection.

  1. Typical Postgres "sslmode" options not supported.

Unleash builds directly on node-postgres and we sometimes get questions if Unleash could support specific sslmodes. The underlying library does no longer support all the sslmodes (announcement) and Unleash cannot support all of them for this reason.

The most asked about is "sslmode=prefer" (eg. #1138), and we can simply not support that as long as the driver does not do that. You need to know upfront if you require a SSL connection or not.

  1. DATABASE_SSL environment variable

We are simply passing the ssl options directly to node-postgres. To make it more convenient for the user we also allow the DATABASE_SSL to be written as JSON and will parse that variable on startup and pass the result to the node-postgres library. We should create some real examples on how this looks like, to make people less confused (e.g #1432)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants