Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of knex is breaking the build 🚨 #569

Closed
greenkeeper bot opened this issue Mar 5, 2020 · 4 comments
Closed

An in-range update of knex is breaking the build 🚨 #569

greenkeeper bot opened this issue Mar 5, 2020 · 4 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Mar 5, 2020


☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency knex was updated from 0.20.10 to 0.20.11.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

knex is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 13 commits.

  • 85888ce Prepare to release 0.20.11 (#3689)
  • b80966a Cleanup/extract transaction ordering logic (implementation 2.0) (#3698)
  • 4678359 timeout(..) function clears unnecessary timeouts (#3703)
  • 51052c5 Cleanup/remove dead oracle code (#3697)
  • 05fedd9 Mark missing test cases as "pending" rather than "passed" (#3695)
  • dc30abf bugfix mysql query errors ignored (#3690)
  • b025aea remove dependency on bluebird methods from sources (#3683)
  • 8c07192 #3653 Mark knex arguments of composite/collection types to be readonly (#3680)
  • 3bea3f6 Add OracleDB handling for buffer type in fetchAsString (#3685)
  • 8159f04 Remove dependency on bluebird methods from tests (#3682)
  • c9be848 Update list of maintainers (#3676)
  • f3151bd Cleanup and extract Transaction Workflow logic (rebase) (#3674)
  • eaf0d15 Fix race condition in non-container transactions (#3671)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Mar 5, 2020

After pinning to 0.20.10 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@ivarconr
Copy link
Member

ivarconr commented Mar 5, 2020

Error:

TypeError: this.db.select(...).from(...).limit(...).whereRaw(...).orderBy(...).map is not a function

...This happens because knex removed "Bluebird" dependency and returns now a pure promise instead. This should have been a major change probably.

Need to rewrite all those .map calls as they are a bluebird specific thing.

@ivarconr
Copy link
Member

ivarconr commented Mar 6, 2020

knex/knex#3704

@ivarconr
Copy link
Member

will be fixed as part of 3.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant