Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bots: missing check for "upward" navcons? #3002

Open
slipher opened this issue May 16, 2024 · 1 comment
Open

Bots: missing check for "upward" navcons? #3002

slipher opened this issue May 16, 2024 · 1 comment
Labels

Comments

@slipher
Copy link
Contributor

slipher commented May 16, 2024

The BotMaybeAttackWhileClimbing function does an assertion that the last taken navcon should be "upward" (endpoint z coordinate >= start point z coordinate). However the function may be entered without any check that a navcon is active. BotMaybeAttackWhileClimbing is called only by BotClimbToGoal, which is called only by BotMoveUpward. If the bot is a Mantis, BotMoveUpward checks that a navcon is active before calling BotClimbToGoal. But if it is a Dretch, no such check is performed.

@sweet235
Copy link
Contributor

I think I forgot to delete this assertion. In an earlier version, there was no wall climb activation. The mantis would try to leap to the higher place.

I guess we can simply delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants