Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this module working on Electron > v14? #55

Open
stoefln opened this issue Nov 28, 2022 · 3 comments
Open

Is this module working on Electron > v14? #55

stoefln opened this issue Nov 28, 2022 · 3 comments

Comments

@stoefln
Copy link

stoefln commented Nov 28, 2022

Is this fork of opencv4nodejs context-aware by now?
As stated in electron/electron#18397, Electron is not going to support non context-aware modules anymore.

@UrielCh
Copy link
Owner

UrielCh commented Nov 28, 2022

Check these commit:

UrielCh/opencv-electron@67d83d0

by https://github.com/zcmgyu

@stoefln
Copy link
Author

stoefln commented Nov 29, 2022

Interesting. Looks like it's working then.
I still wonder if this has been properly tested with electron.
If you read "What does this look like for Native Module X?" in electron/electron#18397, it seems that there are some code changes needed. Like in there example: https://github.com/CharlieHess/node-mac-notifier/pull/32/files

I can't find "NAN_MODULE_WORKER_ENABLED" anywhere in your repo. 🤔

@liuxiaoxinxin
Copy link

liuxiaoxinxin commented Mar 30, 2023

Can try the forked: https://github.com/liuxiaoxinxin/npm-opencv-build
Specifically, process.env.OPENCV_BIN_DIR is allowed to be set externally to support Electron's different development environment directories and production environment directories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants