Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor attrs and typing #19

Closed
tmr232 opened this issue May 26, 2023 · 1 comment · Fixed by #22
Closed

Vendor attrs and typing #19

tmr232 opened this issue May 26, 2023 · 1 comment · Fixed by #22

Comments

@tmr232
Copy link
Member

tmr232 commented May 26, 2023

Github is dropping support for Python 2.7 - actions/setup-python#672

This means that using Python2 to fetch and install attrs and typing for Jython (

- name: Setup python
uses: actions/setup-python@v2
with:
python-version: "2.7"
- uses: er28-0652/setup-ghidra@master
with:
version: "${{ needs.set-versions.outputs.ghidra-ver }}"
- name: Prepare Jython Environment
run: |
pip2.7 install --target="$GHIDRA_INSTALL_DIR/Ghidra/Features/Python/data/jython-2.7.2/Lib/site-packages" attrs typing
pip2.7 install --target="$GHIDRA_INSTALL_DIR/Ghidra/Features/Python/data/jython-2.7.3/Lib/site-packages" attrs typing
) will stop working soon.

I think the best solution is to vendor those packages, and copy things over ourselves (as we won't have pip).

@tmr232
Copy link
Member Author

tmr232 commented May 26, 2023

I ran a terrible hack (#20 ) to get the Jython site packages from the CI.
We now need to:

  1. Put in it the repo (and list licenses!)
  2. Change the CI task to copy that over instead of installing Python2.7 and running pip.

jython-site-packages.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant