Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to distinguish MOS in group call? #20

Closed
IlgamGabdullin opened this issue May 6, 2024 · 4 comments
Closed

How to distinguish MOS in group call? #20

IlgamGabdullin opened this issue May 6, 2024 · 4 comments

Comments

@IlgamGabdullin
Copy link
Contributor

Hi! How can I distinguish inbound MOS if I have several participants in videocall?

I want to connect partner id's and inbound mos value

@IlgamGabdullin
Copy link
Contributor Author

I'd want to make a pr with the needed changes which lets us to distinguish several inbound stats by some id.

As I saw in the code, CompositeStatsParser.addPeerConnection has 'id' in params (interface AddConnectionPayload), but it never gets back to the client.

The possible solution I see is to change params of method handleNewPeerConnection(pc) to handleNewPeerConnection(pc, id?), then pass the id to addPeerConnection({pc, id}), and emit the id back to the client in callbacks like onIssues and onNetworkScoresUpdated

If you have any concerns on why the solution above might not work, lets discuss

@evgmel
Copy link
Collaborator

evgmel commented May 8, 2024

Hi @IlgamGabdullin, thank your for reaching out.
If I got your question right, you can make the match by ssrc that is returned with issues.
Your suggested changes look useful, but it's better if you could create a PR so that our community could look through the suggested changes. Please, try not to make breaking changes in your proposal PR

@IlgamGabdullin
Copy link
Contributor Author

make the match by ssrc that is returned with issues.

Thank you for your answer! Seems like issues could be matched as you said, but mos could not (does not have ssrc field in NetworkScores).

I will come back with pr

@desher
Copy link
Contributor

desher commented May 16, 2024

@IlgamGabdullin thank you for your contribution! Look forward to further cooperation

@desher desher closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants