Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary waveform viewer #1002

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Mar 12, 2024

Closes #970

Haven't really had time to test this fully, so putting in draft. But since it seems like 5.0 is upcoming, this may be something to consider.

Basically, there is a --viewer argument that lets you select a wave form viewer. Also, all --gtkwave-* arguments are renamed --viewer-*, but with aliases.

(At least that is the idea once fully working.)

Motivated by https://surfer-project.org/ that is beginning to gain some traction. (Although possible to run in the browser there are also native versions.)

@oscargus oscargus force-pushed the viewer branch 5 times, most recently from a32cf67 to 829e97b Compare March 12, 2024 10:25
@umarcor
Copy link
Member

umarcor commented Mar 12, 2024

But since it seems like 5.0 is upcoming, this may be something to consider.

We cannot deprecate gtkwave arguments in the next release. We need to first release a version with the new feature, announcing that "old" aliases will be removed in a future version. Then, in a future release, we can remove the deprecated keywords/arguments.
Therefore, this PR will not introduce breaking changes, and we can have it merged as soon as it is ready (no matter if it's 5.0 or 5.1).

Other than that, this looks very interesting. So, if it's ready by the time we want to tag 5.0, we can sure have it merged before.

@oscargus
Copy link
Contributor Author

The thing I am unsure how to handle are the option strings. Is there some previous example of aliasing those? But if the purpose is to deprecate in the long run, maybe they need to be handled explicitly anyway, so duplicated arguments and then check which has information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters for alternative wave form viewer
3 participants