Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: show complition errors via browserSync fullscreen message #90

Open
dkrnl opened this issue Feb 25, 2021 · 1 comment
Open

Comments

@dkrnl
Copy link

dkrnl commented Feb 25, 2021

Hi!
Thx for browser-sync-webpack-plugin!

I got an idea: show error overlay , when webpack done compliation with errors.

Оriginal code from browsersync recipes:

// pseodo code
bundler.plugin('done', function (stats) {
    if (stats.hasErrors() || stats.hasWarnings()) {
        return browserSync.sockets.emit('fullscreen:message', {
            title: "Webpack Error:",
            body:  stripAnsi(stats.toString()),
            timeout: 100000
        });
    }
    browserSync.reload();
});

Question: can i create pull request this new feature?

@Va1
Copy link
Owner

Va1 commented Feb 25, 2021

hi @dkrnl

you're very welcome :)

to your question:
yes, sounds like a nice idea and you surely can implement it and submit a PR. the code of the plugin is fairly simple, so i think it won't be problematic. however, we have no tests and i, personally, have no project to test against. so, please, test thoroughly yourself and paste some screenshots of the overlay.

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants