Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General UX Additions #25

Open
sanozie opened this issue Jan 1, 2022 · 1 comment
Open

General UX Additions #25

sanozie opened this issue Jan 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@sanozie
Copy link

sanozie commented Jan 1, 2022

For my project, I was planning on making some edits to the user experience of the cropper:

  1. Putting a blur background filter on the outside dark section, optionally
  2. Allowing the user to put their own "crop/submit" and "cancel" buttons under the highlighted area being cropped

For the custom buttons, I was thinking of using a slot, which might open up the possibility to add any kind of content under (and maybe also above) the cropper. For now, I'm planning on forking the repo and adding my edits there, but let me know if this sounds like a good idea to add to the main repo!

@ValentinH
Copy link
Owner

Thanks for these suggestions.

Regarding point 1, it could be a nice option indeed. However, if this can already be achieved with pure CSS, it might be better to let users do it by overidding the stules.

Regarding point 2, I don't think this should be part of the library. You can simply create a wrapper component that would display both the cropper and any buttons you need.

@ValentinH ValentinH added the enhancement New feature or request label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants