Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lava and water blocks in c0.30 CPE (Feature Request) #152

Open
4194304 opened this issue Jun 24, 2023 · 25 comments
Open

Lava and water blocks in c0.30 CPE (Feature Request) #152

4194304 opened this issue Jun 24, 2023 · 25 comments
Labels
enhancement New feature or request

Comments

@4194304
Copy link

4194304 commented Jun 24, 2023

Water and lava buckets can only be accessed if you turn off the restricted inventory, and they do not turn into stone like other items.
Water and lava should not be present in the normal c0.30 inventory but should be present in the c0.30 CPE inventory since it is an extension, and also on many classic servers you can build with lava and water without it spreading everywhere.
Lava and water buckets on normal c0.30 turn into wool when placed, but on CPE they turn into lava and water as expected.
This would fit really nicely since the functionality is fully implemented, but is only accessible if you turn off a setting that affects gameplay.
Also if possible, create an option to disable the chat length limit in older versions, it is pretty irritating

@4194304 4194304 changed the title Lava and water blocks in c0.30 CPE Lava and water blocks in c0.30 CPE (Feature Request) Jun 24, 2023
@FlorianMichael
Copy link
Member

What do you mean by chat length limitation? ViaFabricPlus should have the same limitation that the normal client also has

@4194304
Copy link
Author

4194304 commented Jun 24, 2023

what I mean by chat length limitation is how it limits how many characters you can type in the chat
2023-06-24_13 42 07

@4194304
Copy link
Author

4194304 commented Jun 24, 2023

Also as a bit of a side thought, have you ever thought about making brown wool turn into teal wool and black wool turn into violet wool? Teal wool displays as lime wool and violet wool displays as magenta wool, so there is no way to place teal wool or violet wool without ClassiCube or c0.30.

@FlorianMichael
Copy link
Member

The chat length in the Classic should actually always be: 64 - username length - 2, unless the server is CPE and has LONGER_MESSAGES installed, then the Maximum length is Short.MAX_VALUE * 2 (65534)

@FlorianMichael
Copy link
Member

Water and lava buckets can only be accessed if you turn off the restricted inventory, and they do not turn into stone like other items. Water and lava should not be present in the normal c0.30 inventory but should be present in the c0.30 CPE inventory since it is an extension, and also on many classic servers you can build with lava and water without it spreading everywhere. Lava and water buckets on normal c0.30 turn into wool when placed, but on CPE they turn into lava and water as expected. This would fit really nicely since the functionality is fully implemented, but is only accessible if you turn off a setting that affects gameplay. Also if possible, create an option to disable the chat length limit in older versions, it is pretty irritating

I don't really understand what exactly is wrong with ViaFabricPlus, if it shouldn't be in a C0.30 inventory, then you shouldn't be able to place it at all, in ViaFabricPlus Water and lava are also only displayed as soon as the server has the extension.

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

On CPE it should as it works properly and most servers fully support lava/water placement, also it is used widely for building on clients like Classicube, that's why

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

ClassicCube mode gets rid of the chat length limit

@FlorianMichael
Copy link
Member

On CPE it should as it works properly and most servers fully support lava/water placement, also it is used widely for building on clients like Classicube, that's why

But I still don't understand concretely what should be changed now, should I just always allow Water/Lava and only translate to wool if the extension is missing?

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

if it turns into wool hide it, if not and the server supports it, show it

@FlorianMichael
Copy link
Member

But why should I add lava/water to the inventory if it's going to be remapped to wool anyway, then you should just take the wool right away?

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

Also is it possible to get this to work #152 (comment)

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

might result in discoloration but it could be worth it if you made it change the wool textures depending on the version you chose

@FlorianMichael
Copy link
Member

Why should I do that, it's completely random? I really do not understand what you want from me, I'm sorry.

@FlorianMichael
Copy link
Member

ClassicCube mode gets rid of the chat length limit

What do you mean by ClassiCube Mode? When you use the ClassiCube client or what?

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

Screenshot 2023-06-24 203438

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

Why should I do that, it's completely random? I really do not understand what you want from me, I'm sorry.

you can't place teal or violet wool

@FlorianMichael
Copy link
Member

Screenshot 2023-06-24 203438

I will not remove the chat limit for the ClassiCube server list, because the chat limit is also in the normal ClassiCube client, otherwise it would be totally unlegit.

@FlorianMichael
Copy link
Member

Why should I do that, it's completely random? I really do not understand what you want from me, I'm sorry.

you can't place teal or violet wool

Does the ClassiCube client not show the two blocks in the inventory or what?

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

ClassiCube allows you to bypass the 64 character chat limit, teal wool displays as lime wool and violet wool appears as magenta wool

@FlorianMichael
Copy link
Member

ClassiCube allows you to bypass the 64 character chat limit, teal wool displays as lime wool and violet wool appears as magenta wool

Yes ClassiCube bypasses the chat limit, but only if the Longer Messages extension is installed on the server, and for that ViaFabricPlus has handling, that should remove the chat limit on servers that have LongerMessages installed, I just tested that again.

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

Maybe OmniArchive's server is weird

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

classicube2
classicube
Top is ViaFabricPlus displaying the wool colors incorrectly, and on bottom is ClassiCube which displays the wool colors correctly

@4194304
Copy link
Author

4194304 commented Jun 25, 2023

some colors appear twice

@FlorianMichael FlorianMichael added the enhancement New feature or request label Jul 18, 2023
@FlorianMichael
Copy link
Member

It will take some time until this issue will be fixed here, because I don't have so much time in the near future, but there will be a new system for all old blocks and CPE blocks in the future with ViaFabricPlus 3.

@4194304
Copy link
Author

4194304 commented Jul 18, 2023

I thought that this issue was dead, but thank you for confirming that this could exist in ViaFabric 3

@FlorianMichael FlorianMichael added v3 Feature/Bug which will be implemented/fixed in ViaFabricPlus v3 and removed v3 Feature/Bug which will be implemented/fixed in ViaFabricPlus v3 labels Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants