Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player placing blocks sound plays twice on hypixel (1.8.x mode) #333

Closed
splice11 opened this issue Jan 27, 2024 · 5 comments
Closed

Player placing blocks sound plays twice on hypixel (1.8.x mode) #333

splice11 opened this issue Jan 27, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@splice11
Copy link

General Information

ViaFabricPlus, Fabric API, Mod Menu, Sodium, No Chat Reports.

Bug Description

When playing on 1.20.4 MC version and using ViaFabricPlus (1.8.x mode, the sound of the player placing blocks will play twice.

output8.webm

Steps to Reproduce

  1. Join Hypixel with 1.8.x compatibility mode.
  2. Play any gamemode where you can place blocks.
  3. Sound of placing will play twice.

Expected Behavior

The sound should only play once.
@splice11 splice11 added the bug Something isn't working label Jan 27, 2024
@FlorianMichael
Copy link
Member

Hi, thanks for the bug report, does this issue only appear on Hypixel or on any server?

@splice11
Copy link
Author

I tried several other servers just now. That also use 1.8.9 I believe and the sound was normal. It only played once.

I think it might be something to do with ping. On hypixel the sound plays when I place the block instantly (as if it was on a single player world) with no ping, and when the server registers that I have placed it, it plays again.

On other servers, the sound played once and was slightly delayed by ping, meaning it only played when the server registered it.

Vanilla 1.8.9.webm
ViaFabricPlus 1.8.9.webm

@FlorianMichael
Copy link
Member

It's weird because this issue only seems to appear on Hypixel

@FlorianMichael FlorianMichael mentioned this issue Feb 8, 2024
Closed
@FlorianMichael FlorianMichael mentioned this issue May 13, 2024
Closed
@FlorianMichael
Copy link
Member

Can you try this out on latest ViaFabricPlus (v3.0.0)? I lately did some changes to sound handling in 1.8->1.9 and I'm curious if they maybe fixed it.

FlorianMichael added a commit to ViaVersion/ViaVersion that referenced this issue May 27, 2024
@FlorianMichael
Improve block break/place detection in 1.8->1.9
440abff 
Servers can send sound packets where the positions have a slight offset. This PR aims to improve the detection to account for that.

Closes ViaVersion/ViaFabricPlus#333
@FlorianMichael FlorianMichael mentioned this issue May 27, 2024
Merged
kennytv pushed a commit to ViaVersion/ViaVersion that referenced this issue May 28, 2024
@FlorianMichael
Improve block break/place detection in 1.8->1.9 (#3886)
d9446ee 
Servers can send sound packets where the positions have a slight offset. This PR aims to improve the detection to account for that.

Closes ViaVersion/ViaFabricPlus#333
@FlorianMichael
Copy link
Member

The issue has been fixed with ViaVersion/ViaVersion#3886 and will be merged into ViaFabricPlus within the next release or via dev builds at https://ci.viaversion.com/view/Platforms/job/ViaFabricPlus/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FlorianMichael @splice11