Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more data validation tests #47

Open
aomi opened this issue Nov 14, 2020 · 0 comments
Open

Add more data validation tests #47

aomi opened this issue Nov 14, 2020 · 0 comments

Comments

@aomi
Copy link
Member

aomi commented Nov 14, 2020

Determine which fields are required and optional. ie. we expect the CRN to be present for every Section etc. etc. Currently we only do simple validation of fields but we should extend this to every attribute and categorize them as required or optional.

This will help us reduce the chance that we provide inaccurate data.

An example of this being done can be seen src/pages/courseListingEntries/__tests__/index.test.ts.
A good first step would be make a general data validation function for each type.
Secondly, analyzing each property (like crn) across all sections, classes etc. and analyze the values they are assigned.

For example, we currently don't know what the instructors is formatted like and if we can do any further data extraction. So far, this instructors attribute usually has a (P) likely showing that they are a professor but it would be nice to see if there are any others like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant