fix/disappearing-navbar #959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for virtual-coffee-io processing.
|
2 tasks
danieltott
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Hey @sameer-soni - thanks for the PR!
The issue here isn't that it's hidden on the home page - that is the expected behavior.
The problem is that when the page overscrolls, the nav-bar becomes visible.
Check out the video and my suggestion in the original issue.
To sum up:
- Nav bar should be initially hidden on the home page
- Nav bar should be visible if it has focus
- Nav bar should scroll into view on home page
- No pages should overscroll past the top
|
@sameer-soni Are you interested in fixing this up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue
fixed: #823
Description
The problem was that the first page has zindex of 1034 higher than the navbar, so when user was in first page, navbar was not showing:
so what i did is, I made the navbar z-index = 2000. I did in .navbar class. Now, it's fixed.
Methodology
Code of Conduct