Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A specific user profile does not load #1478

Closed
10 tasks
szc126 opened this issue May 30, 2023 · 1 comment · Fixed by #1479
Closed
10 tasks

A specific user profile does not load #1478

szc126 opened this issue May 30, 2023 · 1 comment · Fixed by #1479

Comments

@szc126
Copy link
Collaborator

szc126 commented May 30, 2023

Website

VocaDB

Describe the bug

https://vocadb.net/Profile/Flower%20Metal is active account +trusted user, but does not load:

  • has header
  • has the buttons under the header
  • does not have anything else

The API response doesn't immediately look malformed; it has # of edits, rated songs, etc.

To Reproduce

click on the link (I encountered it at https://vocadb.net/Album/Versions/1135 FWIW)

Expected behavior

a normal user profile

Screenshots

from Andreoda:
https://cdn.discordapp.com/attachments/797103264655081492/1113093423898050670/image.png

Desktop (please complete the following information):

n/a

Smartphone (please complete the following information):

n/a

Additional context

n/a

Checklist

Fill out the checklist. Use strikethroughs or leave fields empty if you don't know or are unable to check/test.

  • Searched VocaDB/vocadb for duplicate issues.
  • Tested on the beta site.
  • Checked in Chrome.
  • Checked in Safari.
  • Checked in Edge.
  • Checked in Firefox.
  • Checked in private mode.
  • Cleared browser cache and cookies.
  • Checked the DevTools console.
  • Checked the syslog (mods+ only).
@FinnRG
Copy link
Member

FinnRG commented May 30, 2023

This issue has multiple layers:

  1. The user has a space in their name, which we normally don't allow. It would be interesting to know how they changed their name
  2. This wouldn't normally be a problem, but the exact version of react router (our internal routing library) we are using has a bug, that causes it to not handle spaces correctly ([Bug]: Nested route path not resolved when path has a space in 6.4.3, but used to work on 6.4.2 remix-run/react-router#9580)

So the bug can be fixed with a simple library update, but I should probably activate dependabot to prevent future issues with outdated libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants