Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Cannot query documents without limit using multi2 #2595

Open
EloyID opened this issue Jun 29, 2020 · 1 comment
Open

Cannot query documents without limit using multi2 #2595

EloyID opened this issue Jun 29, 2020 · 1 comment

Comments

@EloyID
Copy link
Contributor

EloyID commented Jun 29, 2020

Before we could query all the documents setting limit = 0 in our query.

Nevertheless, this line

const limit = (props.input && props.input.limit) || (options.input && options.input.limit) || options.limit || defaultInput.limit;

causes limit fallback to 20 (the default value)

const defaultInput = { limit: 20, enableTotal: true, enableCache: false, };

Is this intended to happen or just a regression ? :)

@eric-burel
Copy link
Contributor

Probably a regression.

We probably should test typeof foo.limit === "undefined", so both limit:null and limit:0 allow to bypass the limit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants